Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ros1 fixes early create subscribers #336

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Ros1 fixes early create subscribers #336

merged 4 commits into from
Oct 14, 2022

Conversation

minhquoc0712
Copy link
Collaborator

Fixed:

  • Error related to order of initializing input data node with respect to perception node Ros1 fixes audiovisual emotion recognition #332 in RGBD hand recognition node.
  • Missing output topic name option in node initialization in Heart anomaly detection node.

@minhquoc0712 minhquoc0712 added the test sources Run style checks label Oct 13, 2022
@tsampazk tsampazk self-requested a review October 13, 2022 12:52
tsampazk
tsampazk approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@tsampazk tsampazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minhquoc0712 ! Good catch on the heart anomaly node, changes LGTM.

ad-daniel
ad-daniel approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@ad-daniel ad-daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ad-daniel ad-daniel merged commit e2c932f into develop Oct 14, 2022
@ad-daniel ad-daniel deleted the ros1-fixes-early-create-subscribers branch October 14, 2022 09:09
lucamarchionni pushed a commit to lucamarchionni/opendr that referenced this pull request Jun 10, 2024
@minhquoc0712 @tsampazk
Ros1 fixes early create subscribers (opendr-eu#336)
bbd3964 
* Fix early create subscribers for rgbd hand gesture recognition node

* Fix missing option for output topic name in ros node intialization

Co-authored-by: Kostas Tsampazis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-daniel ad-daniel ad-daniel approved these changes

@tsampazk tsampazk tsampazk approved these changes

@passalis passalis Awaiting requested review from passalis passalis is a code owner

@omichel omichel Awaiting requested review from omichel omichel is a code owner

@stefaniapedrazzi stefaniapedrazzi Awaiting requested review from stefaniapedrazzi stefaniapedrazzi is a code owner

Assignees
No one assigned
Labels
test sources Run style checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minhquoc0712 @tsampazk @ad-daniel